Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource/custom): allow to fetch from TOML data endpoint #25635

Open
secustor opened this issue Nov 7, 2023 · 4 comments · May be fixed by #28594
Open

feat(datasource/custom): allow to fetch from TOML data endpoint #25635

secustor opened this issue Nov 7, 2023 · 4 comments · May be fixed by #28594
Labels
datasource:custom good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@secustor
Copy link
Collaborator

secustor commented Nov 7, 2023 •
edited

Describe the proposed change(s).

Similar to the current json implementation this new toml option should query an http endpoint tough instead toml-eslint-parser should be used as parser

Notes:

  • the request should send the Accept header with application/toml as value
  • After parsing as toml, jsonata rules should be applied
@secustor secustor added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others datasource:custom good first issue Suitable for new contributors labels Nov 7, 2023
@viceice
Copy link
Member

viceice commented Nov 7, 2023

we recently switched the toml parser

@secustor
Copy link
Collaborator Author

secustor commented Nov 7, 2023

Is there a tracking issue for the migration? I see that we still have usages of that package.

@rarkins
Copy link
Collaborator

rarkins commented Nov 8, 2023

Are you sure? I don't see it anywhere including package.json

@viceice
Copy link
Member

viceice commented Nov 8, 2023

@imkarrer imkarrer linked a pull request Apr 22, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource:custom good first issue Suitable for new contributors priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(datasource/custom): add toml support imkarrer/renovate
3 participants
@viceice @rarkins @secustor