feat(manager/gitlabci): support registry aliases #28607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrews
force-pushed
the
gitlab-aliases
branch
from
9536803
to
4b3b957
Compare
6 tasks
secustor
requested changes
Apr 24, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
changed the title
secustor
approved these changes
Apr 24, 2024
viceice
reviewed
Apr 24, 2024
| @@ -120,6 +120,7 @@ function getAllIncludeComponents( | |||
|
|
|||
| function extractDepFromIncludeComponent( | |||
| includeComponent: GitlabIncludeComponent, | |||
| registryAliases?: Record<string, string>, | |||
There was a problem hiding this comment.
Suggested change
| registryAliases?: Record<string, string>, | |
| registryAliases: Record<string, string> | undefined, |
I had preferred this
There was a problem hiding this comment.
I'll keep that in mind for the future... but this has already been merged so what, if anything, should be done now?
|
🎉 This PR is included in version 37.321.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Applies registry aliases in the the GitLab CI manager.
Context
The GitLab CI manager should support registry aliases like many of the other managers already do.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: