Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep comments like ratchet:actions/setup-java@v4 when creating PRs #28645

Open
HonkingGoose opened this issue Apr 25, 2024 · 1 comment
Open

Keep comments like ratchet:actions/setup-java@v4 when creating PRs #28645

HonkingGoose opened this issue Apr 25, 2024 · 1 comment
Labels
manager:github-actions Github actions manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Apr 25, 2024 •
edited

Describe the proposed change(s).

Renovate should keep comments like ratchet:actions/setup-java@v4 when creating the update PR.

Wanted behavior

- uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # ratchet:actions/setup-java@v4

Bugged behavior

- uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # v4

See how Renovate strips the ratchet:actions/setup-java@ part.

More context
@HonkingGoose HonkingGoose added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:github-actions Github actions manager labels Apr 25, 2024
@HonkingGoose
Copy link
Collaborator Author

Hi @art-shutter, you created the "support ratchet comments" PR (#27846). Do you want to work on this bug?

@HonkingGoose HonkingGoose changed the title Keep comments like ratchet:actions/setup-jave@v4 when creating PRs Keep comments like ratchet:actions/setup-java@v4 when creating PRs May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
manager:github-actions Github actions manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HonkingGoose