Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipenv): better python constraints checking #28878

Merged
merged 5 commits into from
May 8, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 6, 2024

Changes

Improves Pipenv Python constraint checking:

  • Check Pipfile first (in preparation for updating this as a dependency)
  • Check .python-version last

Context

Useful for Runinstall

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice May 6, 2024 18:24
@rarkins rarkins enabled auto-merge May 6, 2024 18:24
@rarkins rarkins requested a review from secustor May 7, 2024 05:45
@rarkins rarkins requested a review from viceice May 7, 2024 10:21
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To lazy to create a minimal zod schema 😏

@rarkins rarkins added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 78e3ea6 May 8, 2024
37 checks passed
@rarkins rarkins deleted the feat/pipenv-more-constraints branch May 8, 2024 10:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.351.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants