Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdm): ignore build requirements when update lock file #28946

Merged
merged 6 commits into from
May 10, 2024

Conversation

huxuan
Copy link
Contributor

@huxuan huxuan commented May 9, 2024

Changes

Per discussion here, pdm does not lock build requirements in lock files, in this way, when we update lock file during dependency update, we should also ignore build requirements.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@huxuan huxuan marked this pull request as draft May 9, 2024 05:12
@huxuan huxuan marked this pull request as ready for review May 9, 2024 05:41
@rarkins
Copy link
Collaborator

rarkins commented May 10, 2024

Can these dependencies have "versions" in pyproject.toml? If so then we don't to skip them.

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@huxuan
Copy link
Contributor Author

huxuan commented May 10, 2024

Hi @rarkins, thanks for the attention.

Can these dependencies have "versions" in pyproject.toml? If so then we don't to skip them.

Yep, there do have versions for the build requirements and the version update actually works well. But the error happens when syncing the lock of the corresponding packages AFTER version update because pdm can not find them in the lock files. It is not a blocking error that breaks the version update, but more like a postprocessing error.

You can see the created pull request with errors here and the corresponding GitHub Actions log here

Sorry for the confusion, I should include the pull request and log earlier.

@huxuan huxuan requested a review from viceice May 10, 2024 12:16
@viceice viceice requested a review from rarkins May 10, 2024 12:45
@rarkins rarkins added this pull request to the merge queue May 10, 2024
Merged via the queue into renovatebot:main with commit aa05c66 May 10, 2024
37 checks passed
@huxuan huxuan deleted the xuan.hu/pdm-build-req branch May 10, 2024 13:42
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.354.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants