-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdm): ignore build requirements when update lock file #28946
Conversation
Can these dependencies have "versions" in pyproject.toml? If so then we don't to skip them. |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Hi @rarkins, thanks for the attention.
Yep, there do have versions for the build requirements and the version update actually works well. But the error happens when syncing the lock of the corresponding packages AFTER version update because pdm can not find them in the lock files. It is not a blocking error that breaks the version update, but more like a postprocessing error. You can see the created pull request with errors here and the corresponding GitHub Actions log here Sorry for the confusion, I should include the pull request and log earlier. |
🎉 This PR is included in version 37.354.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Per discussion here, pdm does not lock build requirements in lock files, in this way, when we update lock file during dependency update, we should also ignore build requirements.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: