feat(pip_requirements): Extract flags from package files with no deps #28961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pip_requirements manager is used by the pip-compile manager for extracting info from requirements.in files. This change makes pip_requirements return any flags it extracted from its input file even if there are no dependencies in the file. This allows a user to provide a requirements.in file with nothing but `--extra-index-url` flags as a second input file when using pip-compile to compile dependencies in a setup.py file so that Renovate can look those index URLs up in its `hostRules` and pass appropriate credentials to pip-compile.
viceice
reviewed
May 10, 2024
|
There are cases where we return the package file even with no deps (e.g. when it's the root npm package in workspaces) |
|
If this only concerns pip-compile manager, maybe it should handle this edge-case? Also, maybe extract function can have an optional flag to always return a package file object. A flag only used by pip-compile extract function. But this changes the interface. |
rarkins
approved these changes
May 13, 2024
|
🎉 This PR is included in version 37.358.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mbudnek
deleted the
feat/pip-requirements-extract-flags-from-empty-package-file
branch
zharinov
pushed a commit
to zharinov/renovate
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The pip_requirements manager is used by the pip-compile manager for extracting info from requirements.in files. This change makes pip_requirements return any flags it extracted from its input file even if there are no dependencies in the file. This allows a user to provide a requirements.in file with nothing but
--extra-index-urlflags as a second input file when using pip-compile to compile dependencies in a setup.py file so that Renovate can look those index URLs up in itshostRulesand pass appropriate credentials to pip-compile.Context
#28960
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: