Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): update dockerfileVersions match string #28963

Merged
merged 2 commits into from
May 10, 2024

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented May 9, 2024

Changes

I noticed today that the preset regexManagers:dockerfileVersions matchString was inconsistent with that used in others (eg: githubActionsVersions, gitlabPipelineVersions etc)

Context

Updates the matchString to

  • check for alphanumeric characters before _VERSION
  • allow single quotes

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes May 9, 2024
@setchy setchy changed the title feat: update dockerfileVersions match string feat(preset): update dockerfileVersions match string May 9, 2024
@setchy
Copy link
Collaborator Author

setchy commented May 9, 2024

@rarkins - updated it to also support single quoted values

@rarkins rarkins added this pull request to the merge queue May 10, 2024
Merged via the queue into renovatebot:main with commit 74f1833 May 10, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.354.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the feature/regex-docker-versions branch May 10, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants