Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): update deps in WORKSPACE.bzlmod #29001

Merged
merged 1 commit into from
May 11, 2024

Conversation

aherrmann
Copy link
Contributor

Changes

Bazel workspace dependencies are additionally looked up and updated in WORKSPACE.bzlmod files.

Context

With --enable_bzlmod Bazel module dependencies that are compatible with bzlmod are declared in MODULE.bazel. But, not all dependencies are compatible with bzlmod, yet. Such dependencies can be declared using the old repository rule mechanism in WORKSPACE.bzlmod.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required
    (The documention speaks of WORKSPACE in general)

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

With `--enable_bzlmod` Bazel module dependencies that are compatible
with bzlmod are declared in `MODULE.bazel`. But, not all dependencies
are compatible with bzlmod, yet. Such dependencies can be declared using
the old repository rule mechanism in `WORKSPACE.bzlmod`.
@CLAassistant
Copy link

CLAassistant commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2024

Does it otherwise "just work"? The other files are exactly the same other than the file extension?

@aherrmann
Copy link
Contributor Author

aherrmann commented May 11, 2024

Yes, it works fine for the other files. I noticed that WORKSPACE.bzlmod was missing in aherrmann/rules_zig#301. It correctly updated the other files, but missed https://github.com/aherrmann/rules_zig/blob/main/WORKSPACE.bzlmod and https://github.com/aherrmann/rules_zig/blob/main/e2e/workspace/WORKSPACE.bzlmod.

There is an unrelated issue that I've been meaning to report but haven't gotten around to where it misses the sha256 and strip_prefix attributes in .bzl files, see aherrmann/rules_zig@b1e3b17 for example.

UPDATE Reported here #29004

@rarkins rarkins enabled auto-merge May 11, 2024 11:50
@rarkins rarkins added this pull request to the merge queue May 11, 2024
Merged via the queue into renovatebot:main with commit d96068c May 11, 2024
37 checks passed
@aherrmann aherrmann deleted the bazel-workspace-bzlmod branch May 11, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants