Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): paginate getTeams() #29060

Merged
merged 8 commits into from
May 14, 2024
Merged

fix(azure): paginate getTeams() #29060

merged 8 commits into from
May 14, 2024

Conversation

ddovile
Copy link
Contributor

@ddovile ddovile commented May 14, 2024

Changes

Add pagination to getTeams()

Context

"reviewers": ["<user>"] does not work in cases when more than 100 teams exist.
Without any arguments, the getTeams() call returns only the first 100 teams. If provided reviewers do not belong to any of those, then they are not "valid", hence PR has no assigned reviewers.

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@ddovile ddovile changed the title AZURE: paginate getTeams() fix(azure): paginate getTeams() May 14, 2024
@ddovile ddovile marked this pull request as ready for review May 14, 2024 09:05
@rarkins rarkins requested a review from viceice May 14, 2024 09:33
@rarkins rarkins enabled auto-merge May 14, 2024 10:14
@rarkins rarkins added this pull request to the merge queue May 14, 2024
Merged via the queue into renovatebot:main with commit 8d78ca2 May 14, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.362.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zharinov pushed a commit to zharinov/renovate that referenced this pull request May 15, 2024
Co-authored-by: Dovile Dikoviciute <Dovile.Dikoviciute@bentley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AZDO: paginate getTeams() call as there may exist over 100
6 participants