Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets/workarounds): add bitnami docker versioning #29112

Merged
merged 3 commits into from
May 16, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented May 16, 2024

Changes

Works for almost all bitnami images.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor May 16, 2024 06:26
@viceice viceice changed the title feat(presets): add bitnami docker versioning workaround feat(presets/workarounds): add bitnami docker versioning May 16, 2024
secustor
secustor previously approved these changes May 16, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should support it, but let's get this in first

secustor
secustor previously approved these changes May 16, 2024
@rarkins
Copy link
Collaborator

rarkins commented May 16, 2024

I'd prefer to use matchCurrentValue so that it applies to cases which work

@rarkins rarkins enabled auto-merge May 16, 2024 07:12
@rarkins rarkins added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 66de046 May 16, 2024
37 checks passed
@rarkins rarkins deleted the feat/presets/bitnami-workaround branch May 16, 2024 07:22
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.365.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants