Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add replacements for ZAP org moves #29117

Merged
merged 2 commits into from
May 16, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented May 16, 2024

Changes

Adds replacements for the ZAP images

Context

The ZAP images have moved to another org twice (!) this year:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

⚒️ with ❤️ by Siemens

/cc @nejch @dlouzan

@fgreinacher fgreinacher marked this pull request as ready for review May 16, 2024 10:52
@dlouzan
Copy link

dlouzan commented May 16, 2024

Just a random comment: I find it bizarre that they did not just add some kind of redirect, but completely removed the images available on the previous location (they could start publishing in the new location the newer version). Valid pipelines fail miserably now.

rarkins
rarkins previously approved these changes May 16, 2024
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use American English, so it should be organization. 😉

See: Renovate developer docs, Style Guide, use American English.

lib/config/presets/internal/replacements.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/replacements.ts Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description fields are good now.

I'll let a maintainer review the code.

@viceice viceice added this pull request to the merge queue May 16, 2024
Merged via the queue into renovatebot:main with commit 7df1dc7 May 16, 2024
37 checks passed
@fgreinacher fgreinacher deleted the feat/zap-replacement branch May 16, 2024 13:05
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.367.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants