Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packageRules handle depTypes<->depTypeList #3076

Closed
rarkins opened this issue Jan 16, 2019 · 1 comment
Closed

packageRules handle depTypes<->depTypeList #3076

rarkins opened this issue Jan 16, 2019 · 1 comment
Assignees
@rtaum
Labels
good first issue Suitable for new contributors manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 16, 2019 •
edited

Currently packageRules evaluation (inside lib/util) will compare depTypeList to depType. We need to also compare it against the depTypes array if one is present.
@rarkins rarkins added type:feature Feature (new functionality) ready priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:bundler Bundler (Ruby) package manager labels Jan 16, 2019
@rarkins rarkins assigned rarkins and unassigned rarkins Jan 16, 2019
@rarkins rarkins added the good first issue Suitable for new contributors label Jan 19, 2019
@rtaum rtaum mentioned this issue Jan 20, 2019
Closed
@rarkins rarkins added review and removed ready labels Jan 20, 2019
@rarkins rarkins removed the review label Jan 21, 2019
@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.176.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtaum rtaum

Labels
good first issue Suitable for new contributors manager:bundler Bundler (Ruby) package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: compare depTypes to depType (WIP) rtaum/renovate
3 participants
@rarkins @rtaum @renovate-bot