Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise on issues/PRs from Renovate PR changelog links #3082

Closed
edmorley opened this issue Jan 18, 2019 · 6 comments
Closed

Noise on issues/PRs from Renovate PR changelog links #3082

edmorley opened this issue Jan 18, 2019 · 6 comments
Assignees
Labels
platform:github GitHub Platform priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality

Comments

@edmorley
Copy link
Contributor

What Renovate type are you using?
Renovate GitHub App

Describe the bug
The filtering of changelog entries in Renovate PR descriptions to ensure that they don't cause issue backlinks isn't always working, in that:

  • the issues still get linked with a real link (rather than the redirect domain), so cause linkback spam on the issues in question
  • (less important) the formatting of the changelog ends up broken

To Reproduce
Follow one of the issues linked in the Renovate PR here:
mozilla/treeherder#4472

...eg:
jsx-eslint/eslint-plugin-react#2131

...and see all of the links backs that are from Renovate.

Expected behavior
The changelog section rewritten to use the togithub.com redirect domain.

@rarkins rarkins self-assigned this Jan 18, 2019
@rarkins rarkins added type:bug Bug fix of existing functionality ready priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes platform:github GitHub Platform labels Jan 18, 2019
@rarkins
Copy link
Collaborator

rarkins commented Jan 18, 2019

@edmorley thanks for raising this, I'll look into it immediately. I have no idea why our de-linking would not be working all of a sudden

@edmorley
Copy link
Contributor Author

Thank you :-)

I'm guessing it's due to the use of the reference link style?
https://github.com/yannickcr/eslint-plugin-react/blame/e63596406028aa1177056192694d3e7557a29016/CHANGELOG.md#L18

@rarkins
Copy link
Collaborator

rarkins commented Jan 18, 2019

@edmorley yes I think you're exactly right

@rarkins rarkins removed the ready label Jan 18, 2019
@rarkins
Copy link
Collaborator

rarkins commented Jan 18, 2019

This fix should be rolled out to the app shortly. As you're probably aware though, even once we update the PRs across github.com, it doesn't unlink any of the existing "link spam" so it will only help for future PRs.

@edmorley
Copy link
Contributor Author

Amazing - thank you for the quick response!

@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.175.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:github GitHub Platform priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants