New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add validations for aliases #6426
Conversation
@rarkins any thoughts on this PR ? I am not sure if this is the right fix, but happy to contribute if you can guide me. |
@adusumillipraveen we don't actually do the validation you're seeing using a JSON validator - it's an internal tool with a bit more config awareness. So unfortunately I think the solution is instead to add We should check:
|
Thanks @rarkins , i pushed a commit to add specific validations for aliases along with some tests. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if we can reuse the existing is
module for url validation
🎉 This PR is included in version 20.25.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Currently aliases for helm-requirements is failing when configured during nested json validation.
Closes https://github.com/renovatebot/config-help/issues/679