Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pip): support hash updating #6460

Merged
merged 6 commits into from Jun 26, 2020
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 7, 2020

Closes #2444

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2020

This pull request introduces 1 alert when merging 6c682c3 into c3a09c0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@caphrim007
Copy link

@rarkins this PR appears to do what is intended per the results you showed in the linked-to issue. However, when I try to run this via the VSCode docs, I repeatedly get the following

DEBUG: Failed to update requirements/constraints.txt file (repository=org/repo, branch=renovate/regex-2020.x)
       "err": {
         "killed": false,
         "code": 127,
         "signal": null,
         "cmd": "hashin regex==2020.6.8 -r requirements/constraints.txt",
         "stdout": "",
         "stderr": "/bin/sh: 1: hashin: not found\n",
         "message": "Command failed: hashin regex==2020.6.8 -r requirements/constraints.txt\n/bin/sh: 1: hashin: not found\n",
         "stack": "Error: Command failed: hashin regex==2020.6.8 -r requirements/constraints.txt\n/bin/sh: 1: hashin: not found\n\n    at ChildProcess.exithandler (child_process.js:303:12)\n    at ChildProcess.emit (events.js:310:20)\n    at ChildProcess.EventEmitter.emit (domain.js:482:12)\n    at maybeClose (internal/child_process.js:1021:16)\n    at Socket.<anonymous> (internal/child_process.js:443:11)\n    at Socket.emit (events.js:310:20)\n    at Socket.EventEmitter.emit (domain.js:482:12)\n    at Pipe.<anonymous> (net.js:672:12)"
       }

I'm running the latest renovate/python image locally. I also tried building a new image with the inclusion of hashin, however I see in the Typescript that this shouldnt be necessary.

@caphrim007
Copy link

manually installed python-pip in the devcontainer and I can verify that this patch does what I would expect it to do.

Is the inclusion of the docker command in this PR something that would affect self-hosted solutions?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 8, 2020

What exactly are you running? Either you need to have hashin installed locally or you need to run with binarySource=docker. Once this feature is published we will need to add hashin to our “full” Docker image too.

@caphrim007
Copy link

I was just working within the container provided by the .devcontainer under the "VS Code Remote Development" steps found here

https://github.com/renovatebot/renovate/blob/master/docs/development/local-development.md

Regardless, after a little shuffling, I was able to verify that the PR here works.

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 8, 2020

OK great. That container is not intended to have all third party binaries pre-installed, otherwise it would be huge and inconvenient for people developing. Glad you could get it working.

@caphrim007
Copy link

hi @rarkins, anything that I can do to assist in nudging this forward? Thanks.

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 22, 2020

Hopefully just needs some test additions to bring coverage back up to 100%

@rarkins rarkins marked this pull request as ready for review June 26, 2020 07:58
@rarkins rarkins merged commit 8302fb7 into master Jun 26, 2020
@rarkins rarkins deleted the feat/2444-pip-requirements-hashes branch June 26, 2020 08:59
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(pip_requirements): support hashes
3 participants