New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pip): support hash updating #6460
Conversation
This pull request introduces 1 alert when merging 6c682c3 into c3a09c0 - view on LGTM.com new alerts:
|
@rarkins this PR appears to do what is intended per the results you showed in the linked-to issue. However, when I try to run this via the VSCode docs, I repeatedly get the following
I'm running the latest renovate/python image locally. I also tried building a new image with the inclusion of hashin, however I see in the Typescript that this shouldnt be necessary. |
manually installed python-pip in the devcontainer and I can verify that this patch does what I would expect it to do. Is the inclusion of the docker command in this PR something that would affect self-hosted solutions? |
What exactly are you running? Either you need to have hashin installed locally or you need to run with binarySource=docker. Once this feature is published we will need to add hashin to our “full” Docker image too. |
I was just working within the container provided by the https://github.com/renovatebot/renovate/blob/master/docs/development/local-development.md Regardless, after a little shuffling, I was able to verify that the PR here works. |
OK great. That container is not intended to have all third party binaries pre-installed, otherwise it would be huge and inconvenient for people developing. Glad you could get it working. |
hi @rarkins, anything that I can do to assist in nudging this forward? Thanks. |
Hopefully just needs some test additions to bring coverage back up to 100% |
🎉 This PR is included in version 21.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #2444