Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests to use nock instead of got mock #6466

Closed
viceice opened this issue Jun 8, 2020 · 4 comments · Fixed by #6519 or #6523
Closed

refactor tests to use nock instead of got mock #6466

viceice opened this issue Jun 8, 2020 · 4 comments · Fixed by #6519 or #6523
Assignees
@zharinov
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
HTTP Redesign

Comments

@viceice
Copy link
Member

viceice commented Jun 8, 2020

We should replace all got mocks by nock in tests, so #6356 would become easier
@viceice viceice added ready priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels Jun 8, 2020
@viceice viceice added this to To do in HTTP Redesign Jun 8, 2020
@zharinov zharinov self-assigned this Jun 13, 2020
This was referenced Jun 13, 2020
Merged
Merged
HTTP Redesign automation moved this from To do to Done Jun 16, 2020
@rarkins
Copy link
Collaborator

rarkins commented Jun 16, 2020

image

@rarkins rarkins reopened this Jun 16, 2020
@rarkins rarkins closed this as completed Jun 16, 2020
@viceice
Copy link
Member Author

viceice commented Jun 16, 2020

I think this should be reopened, because the are some left got mocks

@viceice viceice reopened this Jun 16, 2020
@viceice
Copy link
Member Author

viceice commented Jun 16, 2020

Ref #6523

@viceice viceice moved this from Done to In progress in HTTP Redesign Jun 16, 2020
@viceice viceice moved this from In progress to Needs Requirements in HTTP Redesign Jun 16, 2020
@viceice viceice moved this from Needs Requirements to In progress in HTTP Redesign Jun 16, 2020
@zharinov zharinov mentioned this issue Jun 16, 2020
Merged
HTTP Redesign automation moved this from In progress to Done Jun 16, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zharinov zharinov

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
No open projects
HTTP Redesign
  
Done
Milestone
No milestone
4 participants
@zharinov @viceice @rarkins @renovate-release