New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internal): datasource registryStrategy #6549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datasource implementations can export a `registryStrategy` field that is used by the datasource index/controller to manage the approach: - ‘first’: send only the first registryUrl - ‘hunt’: return the first successful result - ‘merge’: try all registries and combined/deduplicate the results Closes #6533
viceice
requested changes
Jun 19, 2020
…ource-registry-strategy
viceice
requested changes
Jun 19, 2020
viceice
approved these changes
Jun 19, 2020
🎉 This PR is included in version 21.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datasource implementations can export a
registryStrategy
field that is used by the datasource index/controller to manage the approach:This way they don't all need to reimplement the same logic.
Closes #6533