New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abortOnError / abortIgnoreStatusCodes #6556
Conversation
TODO:
|
@JamieMagee @viceice what do you think about this approach? I think it achieves the flexibility necessary without being too confusing. Even the basic examples given in documentation can be turned into in-built presets to make it simpler still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this approach. 👍
Yeah, also sounds good to me. I like the composability we gain with |
Waiting on #6563 |
This pull request introduces 1 alert when merging 074b693 into 02e6817 - view on LGTM.com new alerts:
|
🎉 This PR is included in version 21.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR adds the ability for users to customize which hosts throw
DatasourceError
s and for which HTTP status codes.abortOnError
can be used to opt-in certain host types or specific hosts such that they throwDatasourceError
and abort the run, whileabortStatusCodes
allows for the list of status codes to be customized.Sets groundwork for #5557