Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ExternalHostError #6563

Merged
merged 12 commits into from Jun 22, 2020
Merged

refactor: ExternalHostError #6563

merged 12 commits into from Jun 22, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 22, 2020

Refactors existing datasource and platform error handling into a single ExternalHostError concept.

@rarkins rarkins requested a review from viceice June 22, 2020 10:39
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2020

This pull request introduces 1 alert when merging 08cfd85 into 1a066c6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things

lib/datasource/docker/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/docker/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/maven/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/npm/index.spec.ts Outdated Show resolved Hide resolved
lib/datasource/npm/index.spec.ts Outdated Show resolved Hide resolved
lib/platform/github/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice June 22, 2020 14:40
@rarkins rarkins merged commit 52a074e into master Jun 22, 2020
@rarkins rarkins deleted the refactor/external-host-error branch June 22, 2020 19:28
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants