Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbt): Support private variable version resolving #6565

Conversation

yamachu
Copy link
Contributor

@yamachu yamachu commented Jun 22, 2020

ref: #3827

Thanks to #3828 , I could update scala packages automatically.

In my use case, I make private variable which shows package version.

For example

Dependencies.scala

object Dependencies
{
  private val somePackageVersion = "1.2.3"
  private val anotherPackageVersion = "2.3.4"
  
  private val somePackage = "foo" % "bar" % somePackageVersion
  private val anotherPackage = "buz" % "piyo" % anotherPackageVersion

  lazy val myAwesomeLibraryDependencies = Seq(somePackage, anotherPackage)
}

build.sbt

~...

libraryDependencies ++= myAwesomeLibraryDependencies

If renovate supports private variable, it would be able to parse this structure.

@yamachu yamachu changed the title Support private variable version resolving feat(sbt): Support private variable version resolving Jun 22, 2020
@yamachu yamachu force-pushed the feat/sbt-support-variables-with-private-prefix branch from c18dc8c to fdd6e9c Compare June 22, 2020 16:44
@rarkins rarkins requested review from zharinov and ikesyo June 22, 2020 18:36
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yamachu, looks good to me

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regex should be constant in module scope.

@rarkins
Copy link
Collaborator

rarkins commented Jun 22, 2020

@viceice is that related to this PR specifically, or something should be refactored before or after?

@rarkins rarkins merged commit aa9a004 into renovatebot:master Jun 22, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yamachu
Copy link
Contributor Author

yamachu commented Jun 23, 2020

Thanks!

@yamachu yamachu deleted the feat/sbt-support-variables-with-private-prefix branch June 23, 2020 01:19
@rarkins
Copy link
Collaborator

rarkins commented Jun 23, 2020

@yamachu thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants