Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lerna): ignore scripts #6581

Merged
merged 2 commits into from Jun 25, 2020
Merged

fix(lerna): ignore scripts #6581

merged 2 commits into from Jun 25, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 24, 2020

Closes #6470

@@ -20,7 +20,7 @@ Array [
},
},
Object {
"cmd": "lerna bootstrap --no-ci -- --no-audit --package-lock-only",
"cmd": "lerna bootstrap --no-ci -- --ignore-scripts --no-audit --package-lock-only",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one have changed? It's adding in the flag where it wasn't present before.

lib/manager/npm/post-update/lerna.ts Show resolved Hide resolved
@@ -20,7 +20,7 @@ Array [
},
},
Object {
"cmd": "lerna bootstrap --no-ci -- --no-audit --package-lock-only",
"cmd": "lerna bootstrap --no-ci -- --ignore-scripts --no-audit --package-lock-only",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong

@rarkins rarkins merged commit ceb7c22 into master Jun 25, 2020
@rarkins rarkins deleted the fix/6470-lerna-scripts branch June 25, 2020 05:43
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm prepare script run when lerna is passed --ignore-scripts
3 participants