New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: repositoryCache #6589
feat: repositoryCache #6589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we try to have all caches with nearly same API and behavior? 🤔
Why using json files instead of global cache? I think a checkbox in master issue for repo cache clean on next run makes sense. |
From a "layered security" point of view, the global cache should contain as little provate information as possible, in case there were ever a leak. I renamed it to "package cache" recently to reflect that, and will keep trying to tighten it up. Whereas this repo cache should have a better level of protection in the app (I will ensure it's copied and erased after each repo). For typical users, these JSON files are essentially going to sit alongside the global/package cache in
Yes, that would be a good feature to add, but I won't do it right away. For now the feature will default to false anyway. |
# Conflicts: # lib/workers/repository/init/config.ts # package.json
@viceice ready to merge this now with limited API but using types instead. please let me know if you spot any problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with it for now, as it's experimental and disabled by default. We can optimize the api later.
Just some small suggestions.
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 21.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Adds a new capability to cache manager extract results per-branch. If the commit as well as the config haven't changed then the previously extracted results are reused.