Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitea): don't crash on empty body during pagination #6598

Merged
merged 5 commits into from Jun 27, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 27, 2020

Fixes #6600

         {
           "name": "renovate",
           "level": 50,
           "logContext": "KVZYKAwSe",
           "repository": "***",
           "err": {
             "message": "pc.push is not iterable (cannot read property Symbol(Symbol.iterator))",
             "stack": "TypeError: pc.push is not iterable (cannot read property Symbol(Symbol.iterator))\n    at GiteaHttp.request (/usr/src/app/node_modules/renovate/dist/util/http/gitea.js:46:20)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)\n    at async GiteaHttp.requestJson (/usr/src/app/node_modules/renovate/dist/util/http/index.js:135:21)\n    at async Object.searchIssues (/usr/src/app/node_modules/renovate/dist/platform/gitea/gitea-helper.js:145:17)\n    at async Proxy.ensureIssueClosing (/usr/src/app/node_modules/renovate/dist/platform/gitea/index.js:553:27)\n    at async Object.exports.isOnboarded (/usr/src/app/node_modules/renovate/dist/workers/repository/onboarding/branch/check.js:51:9)\n    at async Object.checkOnboardingBranch (/usr/src/app/node_modules/renovate/dist/workers/repository/onboarding/branch/index.js:14:29)\n    at async Object.initRepo (/usr/src/app/node_modules/renovate/dist/workers/repository/init/index.js:44:14)\n    at async Object.renovateRepository (/usr/src/app/node_modules/renovate/dist/workers/repository/index.js:37:18)\n    at async Object.start (/usr/src/app/node_modules/renovate/dist/workers/global/index.js:76:13)\n    at async /usr/src/app/node_modules/renovate/dist/renovate.js:28:24"
           },
           "msg": "Repository has unknown error"
         }

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
All committers have signed the CLA.

@CirnoT CirnoT changed the title fix(gitea); don't crash on empty body during pagination fix(gitea): don't crash on empty body during pagination Jun 27, 2020
lib/util/http/gitea.spec.ts Outdated Show resolved Hide resolved
@CirnoT CirnoT requested a review from viceice June 27, 2020 07:39
viceice
viceice previously approved these changes Jun 27, 2020
@rarkins rarkins merged commit 58f42b3 into renovatebot:master Jun 27, 2020
@CirnoT CirnoT deleted the patch-1 branch June 27, 2020 08:25
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.18.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate crashes with Gitea if next pagination page is empty
5 participants