Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitea): fetch both open and closed issues #6604

Merged
merged 2 commits into from Jun 27, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 27, 2020

  • Fetch both closed and open issues
  • Explicitly ask for both closed and open PRs (this is default but let's make sure)
  • Don't include PRs when asking for issues

@rarkins
Copy link
Collaborator

rarkins commented Jun 27, 2020

  • Fetch both closed and open issues

Can you clarify what caused you to change this? I ask partly because I want to check we are doing things consistently across all platforms, as I fixed a GitLab issues bug just now too.

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 27, 2020

I just noticed this when working on other PR.

By default Gitea returns only open issues, I don't think Renovate cares much whether it finds issue in closed state or doesn't find it (at least as far as ensureClosing goes) but my general understanding of code is that it expects to have list of both types.

Actually 'all' isn't exactly documented for ListIssues, but it is for PRs (just documentation issue, will be fixed soon) but relevant snippet is here:

	var isClosed util.OptionalBool
	switch ctx.Query("state") {
	case "closed":
		isClosed = util.OptionalBoolTrue
	case "all":
		isClosed = util.OptionalBoolNone
	default:
		isClosed = util.OptionalBoolFalse
	}

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I think we need this to reopen for example the config error issue.

lib/platform/gitea/gitea-helper.ts Outdated Show resolved Hide resolved
@rarkins rarkins changed the title refactor(gitea): fetch both open and closed issues fix(gitea): fetch both open and closed issues Jun 27, 2020
@rarkins rarkins merged commit 72c86c7 into renovatebot:master Jun 27, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.18.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@CirnoT CirnoT deleted the patch-2 branch June 27, 2020 10:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants