Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy git clone/fetch #6616

Closed
rarkins opened this issue Jun 28, 2020 · 2 comments · Fixed by #7006
Closed

Lazy git clone/fetch #6616

rarkins opened this issue Jun 28, 2020 · 2 comments · Fixed by #7006
Assignees
@rarkins
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 28, 2020

What would you like Renovate to be able to do?

Delay cloning or fetching git until it's necessary, and skip it on runs when it's not.

Describe the solution you'd like

The repository cache in #6589 should be expanded to incorporate config about:

  • init/config
  • scan/extract
  • existing branch updates

With lazy git it would mean skipping the git clone/fetch altogether if:

  • the repository default branch commit is unchanged and it was found to be disabled previous run
  • the repository default branch commit is unchanged and no dependencies were extracted the previous run
  • the existing branch updates cached on the previous run are still all "up to date"

Describe alternatives you've considered

Today Renovate eagerly clones/fetches and always performs a full initialization, scan and apply.
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jun 28, 2020
@rarkins rarkins moved this from To do to Blocked in Performance Improvement Jun 28, 2020
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 29, 2020

Waiting on #6607

@rarkins rarkins moved this from Blocked to To do in Performance Improvement Jul 4, 2020
@rarkins rarkins self-assigned this Jul 4, 2020
@rarkins rarkins removed this from To do in Performance Improvement Aug 11, 2020
rarkins added a commit that referenced this issue Aug 15, 2020
@rarkins
refactor(git): lazy sync git
6c8484e 
initRepo no longer immediately performs a git clone or fetch. Instead, exported functions call syncGit() as their first step. This essentially changes nothing just yet, but will allow us to improve application level logic to perform git syncing later in future.

Ref: #6616
@rarkins rarkins mentioned this issue Aug 15, 2020
Merged
rarkins added a commit that referenced this issue Aug 17, 2020
@rarkins
feat(internal): lazy git initialization
0ac3994 
Closes #6616
@rarkins rarkins mentioned this issue Aug 17, 2020
Merged
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 23.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(internal): lazy git initialization renovatebot/renovate
2 participants
@rarkins @renovate-release