fix(maven): Use consistent precision for extended ranges #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
previously approved these changes
Jun 29, 2020
rarkins
reviewed
Jun 29, 2020
lib/versioning/maven/index.spec.ts
Outdated
| ['[1.8,1.9.0.0)', '1.10.1', '[1.8,1.10.1.0)'], | ||
|
|
||
| ['[1.8,1.9)', '1.9.1', '[1.8,1.9)'], | ||
| ['[1.8,1.9)', '1.10.0', '[1.9,1.10)'], |
There was a problem hiding this comment.
If new value is 1.10.0 then shouldn't it be [1.10,1.11) ?
There was a problem hiding this comment.
Agree, it would look better in this context. What upgrade for [1.8, 1.9] and 1.10.0 would be better:[1.8, 1.10] or [1.9, 1.10]? Btw probably we need to think about range strategies other than auto for maven.
There was a problem hiding this comment.
I think it should be 1.11)
There was a problem hiding this comment.
Okay, take a look again, I've made a slightly different implementation
added 2 commits
June 29, 2020 21:47
|
🎉 This PR is included in version 21.21.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6620