Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform-provider): Implement terraform helm chart update #6631

Merged

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Jun 28, 2020

This PR contains following features:

  • implement the renovating of helm_release resources in Terraform code.
  • fix for a not reported bug, which has been introduced earlier. The bug occurs if Terraform modules use a GIT source
  • some refactors?

Closes #6624

I plan to introduce some additional refactors as the extractor code has become quite huge during the last year. Probably pulling out some login into separate files.

@secustor secustor changed the title Implement terraform helm chart update feat(terraform-provider): Implement terraform helm chart update Jun 28, 2020
@rarkins
Copy link
Collaborator

rarkins commented Jun 29, 2020

I plan to introduce some additional refactors as the extractor code has become quite huge during the last year. Probably pulling out some login into separate files.

Once you're done, can you separate the refactor code into its own PR that we merge first?

@secustor
Copy link
Collaborator Author

Yeah, I will do that.

@secustor secustor force-pushed the implement-terraform-helm-chart-update branch from 98a8b96 to db67d02 Compare July 1, 2020 15:59
@secustor secustor marked this pull request as ready for review July 1, 2020 16:26
@rarkins rarkins merged commit f3d920c into renovatebot:master Jul 2, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
@secustor secustor deleted the implement-terraform-helm-chart-update branch January 25, 2022 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update helm charts which are declared in Terraform
4 participants