Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform): Make git to be class-less #6635

Merged
merged 10 commits into from Jul 1, 2020

Conversation

zharinov
Copy link
Collaborator

Closes #6632

lib/platform/git/index.ts Outdated Show resolved Hide resolved
@zharinov zharinov marked this pull request as ready for review June 30, 2020 13:50
lib/platform/github/index.ts Outdated Show resolved Hide resolved
lib/platform/github/index.ts Show resolved Hide resolved
@viceice viceice self-requested a review June 30, 2020 14:27
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first part of review

lib/util/gitfs/git/index.spec.ts Outdated Show resolved Hide resolved
lib/platform/index.ts Outdated Show resolved Hide resolved
lib/platform/azure/index.ts Outdated Show resolved Hide resolved
@zharinov
Copy link
Collaborator Author

Got lots of errors after getRepoStatus() removal, need some time to figure it out

@zharinov
Copy link
Collaborator Author

zharinov commented Jul 1, 2020

Btw can we make it in separate PR?

@rarkins
Copy link
Collaborator

rarkins commented Jul 1, 2020

Btw can we make it in separate PR?

sure

lib/platform/bitbucket-server/index.ts Outdated Show resolved Hide resolved
lib/util/gitfs/git/index.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more small issues

lib/platform/github/index.ts Outdated Show resolved Hide resolved
lib/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/platform/bitbucket/index.ts Outdated Show resolved Hide resolved
lib/platform/azure/index.ts Outdated Show resolved Hide resolved
Sergio Zharinov added 2 commits July 1, 2020 13:37
@rarkins rarkins requested a review from viceice July 1, 2020 09:53
@rarkins rarkins merged commit d144013 into renovatebot:master Jul 1, 2020
@rarkins rarkins deleted the refactor/declassify-platform-git branch July 1, 2020 10:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.21.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor platform/git to be class-less
4 participants