Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(terraform-provider): refactor manager #6637

Merged
merged 10 commits into from Jul 1, 2020

Conversation

secustor
Copy link
Collaborator

This PR refactors the Terraform manager with the target to improve the code readability and minor bug fixes and improvements.

The refactoring has been requested here: #6631 (comment)

@secustor secustor changed the title Terraform provider refactor chore(terraform-provider): refactor manager Jun 29, 2020
@secustor
Copy link
Collaborator Author

secustor commented Jun 30, 2020

@rarkins Can you restart the pipeline?
If I run the testing suite locally, there are no coverage issues.

@viceice
Copy link
Member

viceice commented Jun 30, 2020

@rarkins
Copy link
Collaborator

rarkins commented Jun 30, 2020

@secustor FYI codecov is a bit stricter about how it calculates coverage. @viceice has pasted from their output above

@rarkins rarkins changed the title chore(terraform-provider): refactor manager refactor(terraform-provider): refactor manager Jul 1, 2020
@rarkins rarkins requested a review from viceice July 1, 2020 11:47
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question otherwise LGTM

analyseTerraformModule(dep);
break;
/* istanbul ignore next */
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a requirement of ES-lint, without it the linting fails.

@rarkins rarkins merged commit b71b9f6 into renovatebot:master Jul 1, 2020
@secustor secustor deleted the terraform-provider-refactor branch July 1, 2020 15:19
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.21.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rarkins
Copy link
Collaborator

rarkins commented Jul 5, 2020

@secustor I received thousands of warning messages once I put this change live in the app, e.g.

image

FYI I have lowered this from WARN to TRACE because there seems to be nothing wrong here and it will otherwise spam the logs. If there are any cases you think should be caught and logged at a higher level, another PR would be welcome

@secustor
Copy link
Collaborator Author

secustor commented Jul 5, 2020

Ah sry, I had this already reduced to trace in #6631, but it seems like it got lost during rebasing.

I don't think there is a need to log this on a higher level.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants