New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(terraform-provider): refactor manager #6637
refactor(terraform-provider): refactor manager #6637
Conversation
@rarkins Can you restart the pipeline? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small question otherwise LGTM
analyseTerraformModule(dep); | ||
break; | ||
/* istanbul ignore next */ | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a requirement of ES-lint, without it the linting fails.
🎉 This PR is included in version 21.21.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@secustor I received thousands of warning messages once I put this change live in the app, e.g. FYI I have lowered this from WARN to TRACE because there seems to be nothing wrong here and it will otherwise spam the logs. If there are any cases you think should be caught and logged at a higher level, another PR would be welcome |
Ah sry, I had this already reduced to trace in #6631, but it seems like it got lost during rebasing. I don't think there is a need to log this on a higher level. |
This PR refactors the Terraform manager with the target to improve the code readability and minor bug fixes and improvements.
The refactoring has been requested here: #6631 (comment)