refactor(npm): skip internal packages earlier #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is "breaking" in terms of cache format :-/ edit: will fix that |
rarkins
commented
Jun 30, 2020
| @@ -76,7 +76,7 @@ export interface PackageFile<T = Record<string, any>> | |||
| extends NpmLockFiles, | |||
| ManagerData<T> { | |||
| hasYarnWorkspaces?: boolean; | |||
| internalPackages?: string[]; | |||
| internalPackages?: string[]; // TODO: remove | |||
There was a problem hiding this comment.
Only cached extracts should have this
rarkins
commented
Jun 30, 2020
| 'Dependency is ignored due to being internal' | ||
| ); | ||
| } else if (depConfig.internalPackages?.includes(depName)) { | ||
| // istanbul ignore next | ||
| dep.skipReason = SkipReason.InternalPackage; |
There was a problem hiding this comment.
Need to keep this in for cached extracts
viceice
approved these changes
Jun 30, 2020
|
🎉 This PR is included in version 21.21.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.