New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove authorization header from core.windows.net requests for Azure docker registries #6641
Conversation
This pull request introduces 1 alert when merging 738f5f6 into abfdae3 - view on LGTM.com new alerts:
|
738f5f6
to
09dbe60
Compare
This pull request introduces 1 alert when merging 09dbe60 into 7af01c5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 7e3b216 into a8caa9e - view on LGTM.com new alerts:
|
…zure docker registries
7e3b216
to
a5d4ad6
Compare
This pull request introduces 1 alert when merging a5d4ad6 into a8caa9e - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ae19aa0 into a8caa9e - view on LGTM.com new alerts:
|
🎉 This PR is included in version 21.21.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Add back the logic that remove the authorization header for requests made against Azure blob storage.
It was initially added via this PR #5274, then reverted 74f24d5.
For the unit tests, I'm struggling with mocking the redirect via nock, I'm available on Slack if someone could find time to give me a hint on how to implement that. I couldn't find similar unit tests for the similar Amazon ECR logic.
Closes #6640