fix: remove authorization header from core.windows.net requests for Azure docker registries #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 738f5f6 into abfdae3 - view on LGTM.com new alerts:
|
etiennetremel
force-pushed
the
add-back-pr-5274
branch
from
738f5f6
to
09dbe60
Compare
|
This pull request introduces 1 alert when merging 09dbe60 into 7af01c5 - view on LGTM.com new alerts:
|
viceice
reviewed
Jul 1, 2020
|
This pull request introduces 1 alert when merging 7e3b216 into a8caa9e - view on LGTM.com new alerts:
|
…zure docker registries
etiennetremel
force-pushed
the
add-back-pr-5274
branch
from
7e3b216
to
a5d4ad6
Compare
|
This pull request introduces 1 alert when merging a5d4ad6 into a8caa9e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ae19aa0 into a8caa9e - view on LGTM.com new alerts:
|
viceice
requested changes
Jul 1, 2020
viceice
approved these changes
Jul 1, 2020
|
🎉 This PR is included in version 21.21.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back the logic that remove the authorization header for requests made against Azure blob storage.
It was initially added via this PR #5274, then reverted 74f24d5.
For the unit tests, I'm struggling with mocking the redirect via nock, I'm available on Slack if someone could find time to give me a hint on how to implement that. I couldn't find similar unit tests for the similar Amazon ECR logic.
Closes #6640