feat(pip): support env var interpolation #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Pip v10+, environment variables are supported in requirements.txt files and will be automatically interpolated. This changeset allows Renovate to parse registry URLs conforming to that syntax properly and follow the same approach, eg. by interpolating the environment variables in the same way as would pip. Note that interpolating env vars is hidden behind the trustLevel=high flag, as described in the Renovate docs: https://github.com/renovatebot/renovate/blob/d70b8c1f2fa999be9684a8ca5da3dda8cd2392ab/docs/usage/self-hosted-configuration.md#trustlevel Additionally, we unconditionally strip `"` characters from the same registryUrls as those are optional in the pip spec (with no behavioural impact) but cause lookup errors for Renovate.
|
@viceice sorry about that, should have opened this as a draft. Now ready for review! |
viceice
requested changes
Jul 3, 2020
| describe('lib/manager/pip_requirements/extract', () => { | ||
| delete process.env.PIP_TEST_TOKEN; |
There was a problem hiding this comment.
Move that into before each please. We should also remove it after each test to be sure it would not interfere any other tests in future.
Same for trustLevel.
There was a problem hiding this comment.
Sure thing, done. FYI, I copied this construct from lib/datasource/npm/index.spec.ts, which you might want to update in the same way.
|
🎉 This PR is included in version 21.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Pip v10+, environment variables are supported in requirements.txt
files and will be automatically interpolated. This changeset allows
Renovate to parse registry URLs conforming to that syntax properly and
follow the same approach, eg. by interpolating the environment variables
in the same way as would pip.
Note that interpolating env vars is hidden behind the trustLevel=high
flag, as described in the Renovate docs: https://github.com/renovatebot/renovate/blob/d70b8c1f2fa999be9684a8ca5da3dda8cd2392ab/docs/usage/self-hosted-configuration.md#trustlevel
Additionally, we unconditionally strip
"characters from the sameregistryUrls as those are optional in the pip spec (with no behavioural
impact) but cause lookup errors for Renovate.