fix(pip): fix compatibility with some simple pip indexes #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Jul 2, 2020
Some "simple"-style pip indexes do not conform to the previous
assumption in this method, namely that they must end in `/+simple/` if
they provide only that style of API. Gemfury private indexes, for
example, are assigned as::
pypi.fury.io/<username>
But offer only a simple API, eg. `pypi.fury.io/<username>/<pkg>/json`
will 404.
This changeset ensures Renovate works with indexes like this by adding a
fallback when the json API 404s to attempt the simple API. This is not
an optimal solution, but I could not find any way to be certain we can
determine whether the API will be json or simple in advance of querying
it.
|
@viceice sorry about that, should have opened this as a draft. Now ready for review! |
rarkins
reviewed
Jul 3, 2020
viceice
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some "simple"-style pip indexes do not conform to the previous
assumption in this method, namely that they must end in
/+simple/ifthey provide only that style of API. Gemfury private indexes, for
example, are assigned as::
But offer only a simple API, eg.
pypi.fury.io/<username>/<pkg>/jsonwill 404.
This changeset ensures Renovate works with indexes like this by adding a
fallback when the json API 404s to attempt the simple API. This is not
an optimal solution, but I could not find any way to be certain we can
determine whether the API will be json or simple in advance of querying
it.