Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleteLocalFile join #6654

Merged
merged 1 commit into from Jul 2, 2020
Merged

fix: deleteLocalFile join #6654

merged 1 commit into from Jul 2, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 2, 2020

Code inspection revealed that each caller of this function is passing a relative file name.

@rarkins rarkins requested review from viceice and zharinov July 2, 2020 17:52
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@zharinov
Copy link
Collaborator

zharinov commented Jul 2, 2020

Still needs further restricting code, right?

@rarkins rarkins merged commit a196db4 into master Jul 2, 2020
@rarkins rarkins deleted the fix/delete-local-file branch July 2, 2020 18:16
@rarkins
Copy link
Collaborator Author

rarkins commented Jul 2, 2020

Yes, this is just a fix. Nearly all the fs.deleteFile calls look like they can be converted to deleteLocalFile (they are doing their own join first)

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants