Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support extended Docker configuration options in gitlabci managers #6659

Closed
michael42 opened this issue Jul 3, 2020 · 4 comments · Fixed by #14879
Closed
Labels
manager:gitlabci GitLab CI config files priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality

Comments

@michael42
Copy link

What would you like Renovate to be able to do?
Renovate doesn't pick up our GitLab CI Services that use the extended syntax, for example:

ui-test:
  stage: test
  services:
    - name: internal.docker.hub.company/selenium/standalone-firefox:3.141.59-xenon
      alias: standalone-firefox
    - name: internal.docker.hub.company/selenium/standalone-chrome:3.141.59-xenon
      alias: standalone-chrome

Describe the solution you'd like
Renovate should be able to parse this syntax. I debugged it and found out the whole parsing is done using regular expressions (instead of a YAML parser) and the regex simply doesn't support this format (and many of other syntactically valid variations).

Describe alternatives you've considered
Maybe we can switch to the simplified syntax and use the longer hostnames to access the services, avoiding extended options and not needing the additional support. I'm not sure if/how the 64/255 character-limit for hostname applies to docker services, though.

@rarkins
Copy link
Collaborator

rarkins commented Jul 3, 2020

We actually should be able to switch to plain YAML parsing now. The regex-based approach was done in the days when we needed to be able to pinpoint the exact line, but that is no longer necessary.

@rarkins rarkins added type:bug Bug fix of existing functionality manager:gitlabci GitLab CI config files labels Jul 3, 2020
@rarkins
Copy link
Collaborator

rarkins commented Jul 3, 2020

Recommendation: let's combine gitlabci and gitlabci-includes managers into one (gitlabci) and use YAML parsing. After that, we fix this problem.

@rarkins rarkins added status:blocked Issue is blocked by another issue or external requirement status:in-progress Someone is working on implementation and removed status:in-progress Someone is working on implementation labels Jan 12, 2021
@HonkingGoose
Copy link
Collaborator

@rarkins You said you needed these items done first, before we can proceed with solving this issue?

Recommendation: let's combine gitlabci and gitlabci-includes managers into one (gitlabci) and use YAML parsing.

Just checking in here what the current status of those items is, as you probably know if we did that or not. 😄

@HonkingGoose HonkingGoose added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-5-triage labels Mar 8, 2021
@viceice
Copy link
Member

viceice commented Mar 8, 2021

ref #8810

@viceice viceice closed this as completed Apr 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:gitlabci GitLab CI config files priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants