Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(git): Decouple 'gitfs/fs' and 'gitfs/git' in tests #6661

Merged
merged 5 commits into from Jul 3, 2020

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 3, 2020

This should make further refactoring way easier.

Ref: #6617

@zharinov zharinov requested a review from viceice July 3, 2020 11:42
@zharinov zharinov changed the title refactor(git): Decouple 'git/fs' and 'git/vcs' in tests refactor(git): Decouple 'gitfs/fs' and 'gitfs/git' in tests Jul 3, 2020
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitfs/git seems to be ugly naming, we should rename it in a later pr.

lib/manager/npm/extract/index.spec.ts Show resolved Hide resolved
lib/platform/azure/index.spec.ts Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Jul 3, 2020

We were debating it on slack. Got a better idea? Are you ok with combining or should we put them separate under util?

@rarkins rarkins changed the title refactor(git): Decouple 'gitfs/fs' and 'gitfs/git' in tests test(git): Decouple 'gitfs/fs' and 'gitfs/git' in tests Jul 3, 2020
@rarkins rarkins merged commit 679176f into renovatebot:master Jul 3, 2020
@rarkins rarkins deleted the refactor/gitfs-naming branch July 3, 2020 13:08
@rarkins
Copy link
Collaborator

rarkins commented Jul 3, 2020

Let's keep it moving..

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants