Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify util/git state #6670

Merged
merged 1 commit into from Jul 4, 2020
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 4, 2020

Removes unnecessary newConfig and cwd. However I'm not sure why they were ever this way in the first place - hopefully for legacy reasons that no longer apply.

Removes unnecessary newConfig and cwd.
@rarkins rarkins requested review from zharinov and viceice July 4, 2020 08:14
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is simply some leftover from multiple refactoring

@rarkins rarkins merged commit 807d48e into master Jul 4, 2020
@rarkins rarkins deleted the refactor/git-cwd-config branch July 4, 2020 09:43
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.22.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants