Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Call 'fs-extra' functions via proxies #6683

Merged
merged 2 commits into from Jul 6, 2020
Merged

refactor: Call 'fs-extra' functions via proxies #6683

merged 2 commits into from Jul 6, 2020

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 5, 2020

Ref #6617

viceice
viceice reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have tests instead of ignoring? I know they are only small proxies. 🤔

lib/manager/npm/post-update/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Jul 6, 2020

I don't mind commenting the whole proxy file :)

@rarkins rarkins merged commit c3fc80a into renovatebot:master Jul 6, 2020
@rarkins rarkins deleted the refactor/fs-extra-proxy-functions branch July 6, 2020 09:17
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.23.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dominykas dominykas mentioned this pull request Jul 22, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zharinov @rarkins @renovate-release @viceice