Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): include '@typescript-eslint' with eslint preset #6687

Merged
merged 2 commits into from Jul 6, 2020
Merged

fix(presets): include '@typescript-eslint' with eslint preset #6687

merged 2 commits into from Jul 6, 2020

Conversation

jfairley
Copy link
Contributor

@jfairley jfairley commented Jul 6, 2020

This updates the eslint package preset to include the @typescript-eslint monorepo. This is a suite of plugins and configs that enables eslint to support typescript.

This updates the eslint package preset to include the @typescript-eslint monorepo. This is a suite of plugins and configs that enables eslint to support typescript.
@jfairley jfairley changed the title fix(presets): include '@typesscript-eslint' with eslint preset fix(presets): include '@typescript-eslint' with eslint preset Jul 6, 2020
viceice
viceice previously approved these changes Jul 6, 2020
@jfairley
Copy link
Contributor Author

jfairley commented Jul 6, 2020

I've never used jest snapshots, but I see that I need to update it for this test. I'm looking into how to do that.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rarkins @JamieMagee What do you think?

@rarkins rarkins merged commit ed13e22 into renovatebot:master Jul 6, 2020
@jfairley jfairley deleted the eslint-preset branch July 6, 2020 17:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.23.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants