Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebasing MR gets stuck in a loop and uses up all CI minutes #6690

Closed
k-yle opened this issue Jul 6, 2020 · 5 comments · Fixed by #6691
Closed

Rebasing MR gets stuck in a loop and uses up all CI minutes #6690

k-yle opened this issue Jul 6, 2020 · 5 comments · Fixed by #6691
Assignees
Labels
platform:gitlab GitLab Platform priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality

Comments

@k-yle
Copy link
Contributor

k-yle commented Jul 6, 2020

What Renovate type are you using?

GitLab hosted app

Describe the bug

If you tick the box on a merge request called "If you want to rebase/retry this MR, check this box", Rennovate gets stuck in a loop constantly rebasing and pushing new commits to the branch. This uses up our month's worth of 2000 CI minutes in under half an hour.

image

image

Relevant debug logs

Rennovate config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:base",
    ":githubComToken([REDACTED])"
  ],
  "labels": ["Dependencies"],
  "stabilityDays": 7,
  "prCreation": "not-pending",
  "masterIssue": true,
  "rangeStrategy": "bump"
}

Logs from one of the 100 jobs that started before we could cancel them: https://gist.github.com/k-yle/9326a01eead03b68da3f676bed7381ef

To Reproduce

  1. Use the above config
  2. Wait until a PR is open
  3. Click the box on the PR that says "If you want to rebase/retry this MR, check this box"
  4. Watch all your CI minutes disappear

Additional context

Maybe something to do with stabilityDays, it's quite buggy on GitLab when you combine it with "prCreation": "not-pending"

Not sure if this is relevant but I saw this in the logs, it looks odd, not sure why it says reuseExistingBranch: false because it does re-use the same branch.

L1073: DEBUG: Manual rebase requested via PR checkbox for #505(branch="renovate/ramda-0.x")
L1074: DEBUG: Using reuseExistingBranch: false(branch="renovate/ramda-0.x")
@SpenserJ
Copy link

SpenserJ commented Jul 7, 2020

We had the same issue, and can provide logs if you need some more

@rarkins
Copy link
Collaborator

rarkins commented Jul 7, 2020

If you look in the dashboard, how many Renovate "jobs" were run during this time? I'm interested in whether each rebase somehow trigger another Renovate job? Otherwise it should have run ~hourly if there wasn't any webhook events triggering further runs.

@rarkins rarkins added priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes platform:gitlab GitLab Platform labels Jul 7, 2020
@viceice
Copy link
Member

viceice commented Jul 7, 2020

@rarkins Maybe we have again an issue with not updating pr description after pushing new commit?

@rarkins
Copy link
Collaborator

rarkins commented Jul 7, 2020

@viceice yes, I suspect that too. Curious why so many pipelines triggered though.

@rarkins rarkins self-assigned this Jul 7, 2020
@rarkins rarkins added the type:bug Bug fix of existing functionality label Jul 7, 2020
rarkins added a commit that referenced this issue Jul 7, 2020
rarkins added a commit that referenced this issue Jul 7, 2020
rarkins added a commit that referenced this issue Jul 7, 2020
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 21.24.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:gitlab GitLab Platform priority-1-critical A bad bug or work that is holding up a lot of other important features or fixes type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants