Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pr): pr edited body not comment #6695

Merged
merged 3 commits into from Jul 7, 2020
Merged

feat(pr): pr edited body not comment #6695

merged 3 commits into from Jul 7, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 7, 2020

When a PR is edited, update the body “Rebasing” description instead of adding a PR comment. This means there will no longer be any "PR has been edited" comments on any platform. There may be some left over from PRs created and edited before this change, but I'm guessing hardly any of those will ever be rebased anyway.

Closes #6694

When a PR is edited, update the body “Rebasing” description instead of adding a PR comment.

Closes #6694
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things, otherwise LGTM.

Did you test it against real repo to be save?

lib/config/migration.ts Show resolved Hide resolved
lib/workers/branch/index.ts Outdated Show resolved Hide resolved
lib/workers/branch/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins merged commit 1663058 into master Jul 7, 2020
@rarkins rarkins deleted the feat/6694-pr-edited branch July 7, 2020 12:30
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 21.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "PR has been edited" comment with PR body text
3 participants