npm-shrinkwrap.json renovation failing

[dominykas]

What Renovate type are you using?

Self hosted

Describe the bug

Lock file maintenance for npm-shrinkwrap.json does not get applied

Relevant debug logs

There is a lock file error log with the following stack trace:

TypeError: Cannot read property 'overwrite' of undefined
    at Object.move (/Users/dominykas/devel/projects/test/node_modules/fs-extra/lib/move/move.js:17:26)
    at /Users/dominykas/devel/projects/test/node_modules/universalify/index.js:8:12
    at new Promise (<anonymous>)
    at Object.move (/Users/dominykas/devel/projects/test/node_modules/universalify/index.js:7:14)
    at Object.move (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/util/fs/proxies.js:69:15)
    at Object.generateLockFile (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/manager/npm/post-update/npm.js:87:24)
    at async Object.getAdditionalFiles (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/manager/npm/post-update/index.js:349:21)
    at async Object.processBranch (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/workers/branch/index.js:231:33)
    at async Object.writeUpdates (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/workers/repository/process/write.js:25:21)
    at async Object.update (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/workers/repository/process/extract-update.js:95:15)
    at async Object.renovateRepository (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/workers/repository/index.js:41:21)
    at async Object.start (/Users/dominykas/devel/projects/test/node_modules/renovate/dist/workers/global/index.js:76:13)
    at async /Users/dominykas/devel/projects/test/node_modules/renovate/dist/renovate.js:28:24

To Reproduce

1. Have a repo with an npm-shrinkwrap.json
2. Perform a renovation there

Additional context

I suspect #6617 / #6683 might have broken it?

[rarkins]

This likely needs a reproduction repo to be sure it's fixed. It would also be useful if you can pinpoint which Renovate version exactly it broke in

[dominykas]

It works with 21.31.1 and does not work with 21.31.2.

Will see if I can set up a public repo.

[dominykas]

Sorry, I think I left some typos in the versions there: it's 21.23.1 and 21.23.2.

[dominykas]

And here's a repo for testing: https://github.com/dominykas/test-renovate-6811

[dominykas]

And the error is visible in https://app.renovatebot.com/dashboard#github/dominykas/test-renovate-6811/206202853

[renovate-release]

🎉 This issue has been resolved in version 21.33.13 🎉

The release is available on:

• GitHub release
• 21.33.13

Your semantic-release bot 📦🚀

[dominykas]

Thanks