Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(go): Remove depNameShort usage #8076

Merged
merged 4 commits into from
Feb 5, 2021
Merged

refactor(go): Remove depNameShort usage #8076

merged 4 commits into from
Feb 5, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 18, 2020

Changes:

Replace depName with lookupName and depNameShort with depName.

Context:

#8075

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@viceice
Copy link
Member Author

viceice commented Dec 18, 2020

@rarkins @JamieMagee Do not merge until monday 😉

@viceice viceice marked this pull request as draft January 14, 2021 14:43
@viceice viceice marked this pull request as ready for review February 5, 2021 10:06
@viceice
Copy link
Member Author

viceice commented Feb 5, 2021

#8401 is merged so we can merge this too.

@rarkins rarkins changed the title feat(go): Remove depNameShort usage refactor(go): Remove depNameShort usage Feb 5, 2021
@rarkins rarkins merged commit 8eccebc into master Feb 5, 2021
@rarkins rarkins deleted the fix/go-depname branch February 5, 2021 10:56
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.39.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice mentioned this pull request Feb 15, 2021
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants