Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove manager from PackageFile #8102

Merged
merged 2 commits into from
Dec 21, 2020
Merged

refactor: remove manager from PackageFile #8102

merged 2 commits into from
Dec 21, 2020

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Dec 21, 2020

Changes:

Removes manager from PackageFile interface.

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 21, 2020 10:02
@viceice viceice changed the title refactor: remove manager from PackageRile refactor: remove manager from PackageFile Dec 21, 2020
viceice
viceice approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@viceice viceice left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did a dry run on renovate-tests/renovate-nginx

@viceice viceice enabled auto-merge (squash) December 21, 2020 10:06
@viceice viceice merged commit 5209be3 into master Dec 21, 2020
@viceice viceice deleted the refactor/package-file-manager branch December 21, 2020 10:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice