-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bitbucket-server): Support git over ssh #8115
Conversation
This allows checkout of repositories from bitbucket-server when http access for git is not enabled
@danez any chance you have time to address leftover comments? Looks like PR is close to merge :) |
I will |
Has this been able to be tested on both types of BBS - https URLs and ssh? |
I did with a docker image of bbs version 6.0 and 7.8 locally. |
🎉 This PR is included in version 24.46.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks a ton! |
This allows checkout of repositories from bitbucket-server when http access for git is not enabled
Changes:
initRepo()
I moved the API calls to be done before the actual git clone, so we can read the clone urls from the API response.does not throw
as it was exactly the same asworks
Context:
Fixes #6280
This allows to use bitbucket-server instances where https is turned of for git:
Documentation (please check one with an [x])
TBD: Still missing in self-hosted config, Want to figure out how to handle known_hosts for now. See below
How I've tested my work (please tick one)
I have verified these changes via:
I did run real tests with local docker version of bb version 6.0.11 and 7.8.1.
One important thing: The ssh access did NOT work out of the box, because the host verification was not stored in
known_hosts
. I assume this is not limited to bb-server but also happens with gitlab for example. How is that handled with gitlab? Is this up to the user to add the identification toknown_hosts
on the machine where renovate is running? I couldn't find anything in the docs about this. I see it was mentioned here #4022 (comment) but not sure what the outcome was.