Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logLevel config option #8291

Closed
viceice opened this issue Jan 14, 2021 · 1 comment · Fixed by #9390
Closed

Remove logLevel config option #8291

viceice opened this issue Jan 14, 2021 · 1 comment · Fixed by #9390
Assignees
@viceice @rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented Jan 14, 2021

What would you like Renovate to be able to do?

Insted we should only rely on LOGE_LEVEL env to init logger very early. That way we don't miss any messages which will currently dropped by logLevel option, because logger update is to late.

Did you already have any implementation ideas?
Sure, first deprecate the option and log a warning. On next major release we drop the config option.
@viceice viceice added type:feature Feature (new functionality) breaking Breaking change, requires major version bump status:ready labels Jan 14, 2021
@viceice viceice self-assigned this Jan 14, 2021
@viceice viceice mentioned this issue Jan 14, 2021
Merged
5 tasks
@viceice viceice added status:in-progress Someone is working on implementation and removed status:ready labels Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Merged
@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Mar 8, 2021
rarkins added a commit that referenced this issue Apr 4, 2021
@rarkins
feat: deprecate logLevel in config
3669784 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI.
@rarkins rarkins self-assigned this Apr 4, 2021
@rarkins rarkins mentioned this issue Apr 4, 2021
Merged
6 tasks
rarkins added a commit that referenced this issue Apr 4, 2021
@rarkins
feat: remove logLevel support in config (#9390)
a5c785a 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove logLevel support in config (#9390)
07439a5 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove logLevel support in config (#9390)
070136f 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove logLevel support in config (#9390)
f75d43e 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@rarkins rarkins mentioned this issue Apr 7, 2021
Merged
rarkins added a commit that referenced this issue Apr 7, 2021
@rarkins
feat: remove logLevel support in config (#9390)
c43ff85 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 10, 2021
@rarkins
feat: remove logLevel support in config (#9390)
99da35e 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 11, 2021
@rarkins
feat: remove logLevel support in config (#9390)
82d750b 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 15, 2021
@rarkins
feat: remove logLevel support in config (#9390)
27c3923 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 21, 2021
@rarkins
feat: remove logLevel support in config (#9390)
8d49d51 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove logLevel support in config (#9390)
70119be 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove logLevel support in config (#9390)
089a89c 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove logLevel support in config (#9390)
f74e0d7 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@viceice viceice

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove logLevel support in config renovatebot/renovate
4 participants
@viceice @rarkins @HonkingGoose @renovate-release