Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove depnameShort of terra* and kustomize #8388

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

secustor
Copy link
Collaborator

Changes:

Remove depNameShort of:

  • terraform
  • terragrunt
  • kustomize

Context:

#8075

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@secustor secustor changed the title Remove depname short feat: Remove depname short of terraform, terragrunt and kustomize Jan 22, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possibly a breaking, becuase user configs can use depNameShort which we don't know.

There is also no easy migration.

@viceice
Copy link
Member

viceice commented Jan 22, 2021

@rarkins How should we handle the backward compability? Try to do some config migration? Migration in template processing?

@rarkins
Copy link
Collaborator

rarkins commented Jan 22, 2021

If want to do it in steps then we can do this:

  1. Add logic somewhere around update flattening to set dep.depNameShort ||= dep.depName for backwards compatibility
  2. Refactor managers progressively
  3. Once they're all refactored, add migration logic to search/replace {{depNameShort}} to {{depName}} in renovate config.
  4. Additionally, add logic - maybe during compile step - to log a deprecation warning if we find {{depNameShort}} in any string being compiled
  5. Remove dep.depNameShort ||= dep.depName in a future major release

@viceice viceice mentioned this pull request Jan 22, 2021
5 tasks
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merge now as we already have #8401 merged

@rarkins rarkins changed the title feat: Remove depname short of terraform, terragrunt and kustomize refactor: Remove depnameShort of terra* and kustomize Feb 5, 2021
@rarkins rarkins merged commit 3270c30 into renovatebot:master Feb 5, 2021
@secustor secustor deleted the remove-depnameShort branch February 5, 2021 11:03
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.39.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants