feat: hashedBranchLength option
#8502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
requested changes
Feb 2, 2021
|
thanks for the review. I think I've addressed all of the feedback now. let me know what you think :) |
rarkins
requested changes
Feb 2, 2021
Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
changed the title
maxBranchLength optionhashedBranchLength option
rarkins
approved these changes
Feb 3, 2021
|
anything left for me to do to get this merged? 😅 |
rarkins
changed the title
hashedBranchLength optionhashedBranchLength option
|
thanks! ❤️ |
|
🎉 This PR is included in version 24.37.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
As suggested in #5390, this PR implements a
hashedBranchLengthoption, which causes the branch name to include a hash ofadditionalBranchPrefixandbranchTopic, cut off at the right length.Context:
As the linked issue describes, this option is introduced to fix compatibility with systems that impose a maximum branch name length on the developers. More details on this are described in the issue.
Closes #5390
This is an alternative proposal to #8496 and closes #8496, if merged.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: