Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): add — after rev-parse #8513

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix(git): add — after rev-parse #8513

merged 1 commit into from
Feb 3, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 3, 2021

Changes:

Add -- after git rev-parse to disambiguate.

Context:

Attempt to solve:

err.message | fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree.Use '--' to separate paths from revisions, like this:'git <command> [<revision>...] -- [<file>...]'
-- | --
err.stack | Error: fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree.Use '--' to separate paths from revisions, like this:'git <command> [<revision>...] -- [<file>...]'at GitExecutorChain.onFatalException (/home/ubuntu/renovateapp/node_modules/simple-git/src/lib/runners/git-executor-chain.js:61:87)at GitExecutorChain.<anonymous> (/home/ubuntu/renovateapp/node_modules/simple-git/src/lib/runners/git-executor-chain.js:52:28)at Generator.throw (<anonymous>)at rejected (/home/ubuntu/renovateapp/node_modules/simple-git/src/lib/runners/git-executor-chain.js:6:65)at runMicrotasks (<anonymous>)at processTicksAndRejections (internal/process/task_queues.js:97:5)
err.task.commands.0 | rev-parse
err.task.commands.1 | origin/main

This happens in forkMode when the forked repo already exists and uses master.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@rarkins rarkins merged commit 51f8381 into master Feb 3, 2021
@rarkins rarkins deleted the fix/git-rev-parse branch February 3, 2021 09:30
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Feb 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants