Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): Fix support for docker list manifests #8540

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix(docker): Fix support for docker list manifests #8540

merged 1 commit into from
Feb 4, 2021

Conversation

danez
Copy link
Contributor

@danez danez commented Feb 4, 2021

Changes:

Add a missing n.

Context:

I guess the tests work as they are both (test+code) using this constant, but the actual runs don't work and fail with:

DEBUG: Invalid manifest - returning (repository=INFRASTRUCTURE/security-checker-job)
"manifest": {
"manifests": [
{
"digest": "sha256:3747d4eb5e7f0825d54c8e80452f1e245e24bd715972c919d189a62da97af2ae",
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"platform": {"architecture": "amd64", "os": "linux"},
"size": 528
},
...
],
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"schemaVersion": 2
}

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice
Copy link
Member

viceice commented Feb 4, 2021

My fault. 🤦‍♂️

@rarkins rarkins merged commit 4ab13cc into renovatebot:master Feb 4, 2021
@danez danez deleted the fix-docker branch February 4, 2021 11:32
@rarkins
Copy link
Collaborator

rarkins commented Feb 4, 2021

so close

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.38.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants